Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout for DDPSpawnStrategy #13383

Merged
merged 19 commits into from
Jun 30, 2022
Merged

Set timeout for DDPSpawnStrategy #13383

merged 19 commits into from
Jun 30, 2022

Conversation

lsy643
Copy link
Contributor

@lsy643 lsy643 commented Jun 23, 2022 •
edited by Borda
Loading

What does this PR do?

Be able to set timeout for ddp spawn strategy

Resolves #13211

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@lsy643 lsy643 mentioned this pull request Jun 23, 2022
Closed
awaelchli
awaelchli approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great follow up! Thanks

CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli added feature Is an improvement or enhancement strategy: ddp spawn labels Jun 23, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jun 23, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 23, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@carmocca carmocca enabled auto-merge (squash) June 27, 2022 23:00
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 28, 2022
@awaelchli awaelchli self-assigned this Jun 28, 2022
auto-merge was automatically disabled June 29, 2022 02:35

Head branch was pushed to by a user without write access

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 29, 2022
@awaelchli awaelchli merged commit e0a0d1e into Lightning-AI:master Jun 30, 2022
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@lsy643 @Borda
@carmocca @jerome-habana
Set timeout for DDPSpawnStrategy (Lightning-AI#13383)
fd8afbe 
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@otaj otaj otaj approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@awaelchli awaelchli

Labels
feature Is an improvement or enhancement ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.

Be able to Set Timeout When DDP Strategy is Used
8 participants
@lsy643 @awaelchli @Borda @otaj @justusschock @akihironitta @rohitgr7 @carmocca