Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused pyDeprecate dependency #14472

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Remove the unused pyDeprecate dependency #14472

merged 3 commits into from
Aug 31, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 31, 2022

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

None, at least unless users were relying on our installation

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Aug 31, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 31, 2022
@carmocca carmocca self-assigned this Aug 31, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 31, 2022
@carmocca carmocca mentioned this pull request Aug 31, 2022
11 tasks
@Borda Borda enabled auto-merge (squash) August 31, 2022 15:30
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2022
@Borda
Copy link
Member

Borda commented Aug 31, 2022

Seems it is used in our codebase 😇

@carmocca
Copy link
Contributor Author

Void is a no-op. It's not worth the dependency. Removed in c4cdaf7

@Borda Borda merged commit 10adcd5 into master Aug 31, 2022
@Borda Borda deleted the ci/remove-unused-dep branch August 31, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants