Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the lite DeviceDtypeModuleMixin as protected #14548

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 6, 2022

What does this PR do?

Follow-up to #14511
This class not meant to be public. Added in a time where we didn't care that much about marking API stability.
No usages out there: https://grep.app/search?q=DeviceDtypeModuleMixin

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 6, 2022
@carmocca carmocca enabled auto-merge (squash) September 6, 2022 09:13
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 8a4a3b6 into master Sep 6, 2022
@carmocca carmocca deleted the lite/internal-dtype-mixin branch September 6, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants