Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the payload doc string #14990

Closed
wants to merge 8 commits into from
Closed

Clarification on the payload doc string #14990

wants to merge 8 commits into from

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Oct 4, 2022

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃
cc: @tchaton , @awaelchli

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 4, 2022
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

src/lightning_app/storage/payload.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 4, 2022
Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>
@awaelchli awaelchli added the docs Documentation related label Oct 4, 2022
@awaelchli awaelchli modified the milestones: pl:1.8, app:0.7 Oct 4, 2022
@otaj otaj enabled auto-merge (squash) October 5, 2022 08:25
src/lightning_app/storage/payload.py Outdated Show resolved Hide resolved
src/lightning_app/storage/payload.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready PRs ready to be merged label Oct 7, 2022
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
auto-merge was automatically disabled October 7, 2022 10:24

Head branch was pushed to by a user without write access

@carmocca carmocca removed this from the app:0.7 milestone Oct 13, 2022
@stale
Copy link

stale bot commented Oct 29, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package docs Documentation related won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants