Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JustPy Frontend #15002

Merged
merged 32 commits into from
Oct 27, 2022
Merged

Add JustPy Frontend #15002

merged 32 commits into from
Oct 27, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 5, 2022

What does this PR do?

from typing import Callable

from lightning import LightningApp, LightningFlow
from lightning.app.frontend import JustPyFrontend


class Flow(LightningFlow):
    def __init__(self):
        super().__init__()
        self.counter = 0

    def run(self):
        print(self.counter)

    def configure_layout(self):
        return JustPyFrontend(render_fn=render_fn)


def render_fn(get_state: Callable) -> Callable:
    import justpy as jp

    def my_click(self, *_):
        state = get_state()
        old_counter = state.counter
        state.counter += 1
        self.text = f"Click Me ! Old Counter: {old_counter} New Counter: {state.counter}"

    def website():
        wp = jp.WebPage()
        d = jp.Div(text="Hello ! Click Me!")
        d.on("click", my_click)
        wp.add(d)
        return wp

    return website


app = LightningApp(Flow())

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 5, 2022
@tchaton tchaton self-assigned this Oct 5, 2022
@tchaton tchaton added this to the pl:future milestone Oct 5, 2022
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (a few typos), I'm wondering if we can add a more significant test to detect if the integration stops working. Right now it's just a smoke test.

docs/source-app/workflows/add_web_ui/justpy/index.rst Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py_base.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py_base.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
src/lightning_app/frontend/just_py/just_py.py Outdated Show resolved Hide resolved
Copy link
Contributor

@manskx manskx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢

@mergify mergify bot removed the has conflicts label Oct 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 24, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 24, 2022
@Borda
Copy link
Member

Borda commented Oct 25, 2022

@tchaton, what is blocking this PR? 🦦

@lexierule lexierule merged commit df4b705 into master Oct 27, 2022
@lexierule lexierule deleted the add_justpy_frontend branch October 27, 2022 15:48
@carmocca carmocca modified the milestones: future, v1.8 Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants