-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support individual setup of model and optimizer in Lite #15185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
Is an improvement or enhancement
refactor
fabric
lightning.fabric.Fabric
labels
Oct 19, 2022
for more information, see https://pre-commit.ci
…ning into lite/individual-setup
for more information, see https://pre-commit.ci
…ning into lite/individual-setup
awaelchli
commented
Oct 23, 2022
Borda
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The API looks good to me 🦦
- why are you updating
_notebooks
head? - shall we add also docs update for this?
This PR is a preparation for #14898. I think it will make most sense to add the docs there for full context. |
justusschock
approved these changes
Nov 9, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Nov 10, 2022
for more information, see https://pre-commit.ci
awaelchli
requested review from
carmocca
and removed request for
otaj,
rohitgr7 and
kaushikb11
November 10, 2022 12:08
awaelchli
added
fun
Staff contributions outside working hours - to differentiate from the "community" label
and removed
community
This PR is from the community
labels
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is providing new APIs for setting up model and optimizers to enable FSDP in #14967.
The design considerations were discussed here.
Before:
Model and optimizers had to be set up jointly.
Now:
Jointly setting up model and optimizer is still possible.
For some strategies, this is the only way possible (DeepSpeed).
However, there are strategies (FSDP) that require to set up the model first before the optimizer can be created:
This PR introduces these two new APIs
setup_model
andsetup_optimizers
and the error messaging for which strategies support which setup procedure.Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @awaelchli @carmocca