Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop flattening: remove .replace() #16361

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Loop flattening: remove .replace() #16361

merged 4 commits into from
Jan 16, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 13, 2023 •
edited by github-actions bot
Loading

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Removes Loop.replace()

cc @Borda @justusschock @awaelchli @carmocca

@carmocca carmocca added refactor loops Related to the Loop API pl Generic label for PyTorch Lightning package labels Jan 13, 2023
@carmocca carmocca self-assigned this Jan 13, 2023
@carmocca carmocca changed the base branch from master to lite/debug January 13, 2023 18:25
@carmocca carmocca marked this pull request as ready for review January 13, 2023 18:31
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/loops/test_loops.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/loops/test_loops.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/loops/test_loops.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/loops/test_loops.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to docs/source-pytorch/extensions/loops.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Jan 16, 2023
@carmocca carmocca enabled auto-merge (squash) January 16, 2023 15:30
@carmocca carmocca merged commit 4ecfb55 into lite/debug Jan 16, 2023
@carmocca carmocca deleted the lite/debug-loop-flattening branch January 16, 2023 15:36
carmocca added a commit that referenced this pull request Jan 16, 2023
@carmocca
Remove .replace [rebase and fixup into #16361]
203b2ca
@carmocca carmocca mentioned this pull request Jan 16, 2023
Merged
@carmocca carmocca added the breaking change Includes a breaking change label Jan 16, 2023
carmocca added a commit that referenced this pull request Jan 16, 2023
@carmocca
Remove .replace [rebase and fixup into #16361] (#16383)
b12e957
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
56c2d5f
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
1bb3600
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
3e156ed
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca @Borda
Loop flattening: remove .replace() (#16361)
453761c
@carmocca carmocca added this to the 2.0 milestone Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
979d76c
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
b27c414
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .replace() (#16361)
b9778f9
lantiga pushed a commit that referenced this pull request Jan 19, 2023
@carmocca @lantiga
Loop flattening: remove .replace() (#16361)
e9a5c74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@Borda Borda Awaiting requested review from Borda

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @justusschock