Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making optimization steps for hooks #2363

Merged
merged 7 commits into from
Jun 25, 2020
Merged

making optimization steps for hooks #2363

merged 7 commits into from
Jun 25, 2020

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@mergify mergify bot requested a review from a team June 25, 2020 16:32
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2363 into master will increase coverage by 0%.
The diff coverage is 79%.

@@          Coverage Diff           @@
##           master   #2363   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5543    5555   +12     
======================================
+ Hits         4878    4889   +11     
- Misses        665     666    +1     

@pep8speaks
Copy link

pep8speaks commented Jun 25, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-25 19:38:39 UTC

@Borda Borda added the feature Is an improvement or enhancement label Jun 25, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team June 25, 2020 19:38
@williamFalcon williamFalcon merged commit 0a092f6 into master Jun 25, 2020
@Borda Borda deleted the opt_hook branch June 26, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants