cleaning up stale logger tests + flake8 #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3490 +/- ##
=======================================
+ Coverage 86% 91% +5%
=======================================
Files 107 107
Lines 8063 8007 -56
=======================================
+ Hits 6896 7279 +383
+ Misses 1167 728 -439 |
awaelchli
reviewed
Sep 14, 2020
| MLFlowLogger, | ||
| NeptuneLogger, | ||
| TestTubeLogger, | ||
| WandbLogger, |
There was a problem hiding this comment.
@williamFalcon are these tests causing problems?
There was a problem hiding this comment.
yes... these loggers are having issues where they freeze and such. I’m honestly not sure it’s worth running some of these tests anymore if the loggers aren’t properly designed.
There was a problem hiding this comment.
oh, that's new. I use wandb logger every day non stop and no issues with PL. Can you give me some pointer, I'd like to help fix the root issue.
There was a problem hiding this comment.
in the mean time, can we comment the lines and add a todo note?
There was a problem hiding this comment.
sure. i’ll ping you on slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.