classification metrics #4043
Merged
classification metrics #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ananyahjha93! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-10 15:58:13 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4043 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 105 107 +2
Lines 7815 7920 +105
=======================================
+ Hits 7194 7298 +104
- Misses 621 622 +1 |
Borda
reviewed
Oct 10, 2020
| from pytorch_lightning.metrics.utils import METRIC_EPS | ||
|
|
||
|
|
||
| class Fbeta(Metric): |
There was a problem hiding this comment.
Suggested change
| class Fbeta(Metric): | |
| class FBeta(Metric): |
| @@ -17,3 +20,31 @@ def dim_zero_mean(x): | |||
|
|
|||
| def _flatten(x): | |||
| return [item for sublist in x for item in sublist] | |||
|
|
|||
|
|
|||
| def to_onehot( | |||
There was a problem hiding this comment.
this is already in functional/classification
| from tests.metrics.utils import compute_batch, setup_ddp | ||
| from tests.metrics.utils import THRESHOLD | ||
|
|
||
| from tests.metrics.classification.utils import ( |
There was a problem hiding this comment.
nice 👍
maybe include in the function name that these functions are meant for testing
like _testing_inputs_binary_prob
Borda
requested changes
Oct 10, 2020
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
ananyahjha93
force-pushed
the
metrics/classification
branch
from
f160e38
to
f2f7ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds classification metrics.
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃