Fix bug comparing max_steps to global step which inits at 0 #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
approved these changes
Oct 21, 2020
awaelchli
suggested changes
Oct 21, 2020
SeanNaren
requested review from
ananyahjha93,
nateraw,
teddykoker and
williamFalcon
as code owners
…efore exiting loop in conjuction with max steps
Codecov Report
@@ Coverage Diff @@
## master #4278 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8040 8003 -37
======================================
+ Hits 7440 7441 +1
+ Misses 600 562 -38 |
awaelchli
approved these changes
Oct 22, 2020
tchaton
approved these changes
Oct 22, 2020
Borda
reviewed
Oct 22, 2020
|
|
||
| # progress global step according to grads progress | ||
| if num_accumulated_batches_reached or num_training_batches_reached: | ||
| self.trainer.global_step += 1 | ||
|
|
||
| def accumulated_batches_reached(self): |
There was a problem hiding this comment.
can we have it rather as protected as it is not meant to be used by the user...
There was a problem hiding this comment.
Will make a followup PR
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4193
Just going to make a test before calling this ready for review.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃