[HOTFIX] Logging for evaluation #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
SeanNaren
reviewed
Nov 15, 2020
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
SeanNaren
reviewed
Nov 15, 2020
…rchLightning/pytorch-lightning into bugfix/4681_validation_step
SeanNaren
reviewed
Nov 15, 2020
…rchLightning/pytorch-lightning into bugfix/4681_validation_step
|
looks good. does this also log to the prog bar? |
Codecov Report
@@ Coverage Diff @@
## master #4684 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8921 8922 +1
======================================
+ Hits 8285 8286 +1
Misses 636 636 |
Yes, it should, but I will make sure of this on Monday. |
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* resolve bugs * add should_flush_logs * remove should_flush * should work * update test * use something else * Update pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py * log mock_log_metrics.mock_calls * typo * don't use keys * convert to list * typo * check kwargs * resolve bug * resolve flake8 Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolve a missing self.log_metrics called at the end of an epoch !
Closes #4681
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃