Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat-BugFix] Resolve custom DataLoader #5745

Merged
merged 15 commits into from
Feb 5, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 2, 2021

What does this PR do?

This PR fixes the re-instantiation of custom DataLoader and provides a better error message

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2021

Hello @tchaton! Thanks for updating this PR.

Line 91:29: E203 whitespace before ':'

Comment last updated at 2021-02-04 20:52:40 UTC

@tchaton tchaton self-assigned this Feb 2, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #5745 (12084ad) into release/1.2-dev (d2c2e50) will decrease coverage by 0%.
The diff coverage is 97%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5745    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  181     181            
  Lines                12912   12775   -137     
================================================
- Hits                 11397   11248   -149     
- Misses                1515    1527    +12     

@mergify mergify bot added the has conflicts label Feb 3, 2021
@mergify mergify bot removed the has conflicts label Feb 3, 2021
@Borda Borda added the feature Is an improvement or enhancement label Feb 3, 2021
@mergify mergify bot added the has conflicts label Feb 3, 2021
@mergify mergify bot removed the has conflicts label Feb 4, 2021
@mergify mergify bot added the has conflicts label Feb 4, 2021
@mergify mergify bot removed the has conflicts label Feb 4, 2021
@tchaton tchaton merged commit d8f2d8e into release/1.2-dev Feb 5, 2021
@tchaton tchaton deleted the resolve_custom_dataloader_bug branch February 5, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants