Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PredictLoop #5752

Merged
merged 387 commits into from Feb 16, 2021
Merged

Add PredictLoop #5752

merged 387 commits into from Feb 16, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 2, 2021

What does this PR do?

This PR adds PredictLoop.
Currently the trainer.predict was using EvaluationLoop with trainer.testing.
Now, it uses its own loop and remove the EvaluationLoop dependency to predict.

Fixes #5475

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM

pytorch_lightning/accelerators/accelerator.py Show resolved Hide resolved
pytorch_lightning/callbacks/progress.py Show resolved Hide resolved
pytorch_lightning/callbacks/progress.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@tchaton tchaton added the _Will label Feb 15, 2021
@tchaton tchaton self-assigned this Feb 15, 2021
@mergify mergify bot removed the has conflicts label Feb 15, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and I like the description of the trainer flow, this should definitely make its way to the docs for users if possible!

@tchaton
Copy link
Contributor Author

tchaton commented Feb 16, 2021

Really nice and I like the description of the trainer flow, this should definitely make its way to the docs for users if possible!

Thanks. I was thinking to make a cleaner for the documentation.

Best,
T.C

@tchaton tchaton enabled auto-merge (squash) February 16, 2021 21:55
@tchaton tchaton added the ready PRs ready to be merged label Feb 16, 2021
@tchaton tchaton merged commit e982800 into master Feb 16, 2021
@tchaton tchaton deleted the introduce_predict_loop_1 branch February 16, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Trainer.predict(), similar to Trainer.test(), except returns the predictions
8 participants