Implement TensorboardLogger #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neggert amazing. let's make this the default logger and remove the test-tube dep? |
|
@neggert @williamFalcon There are many bugs in this PR, pls fix them in the follow-up #609 |
Merged
|
btw, the official spelling is TensorBoard (not Tensorboard). I would consider renaming to TensorBoardLogger. |
|
agreed. mind submitting a PR? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simple Tensorboard logger. No more external dependencies for basic logging!
Only question on this one is how to deal with the fact that
SummaryWriter.add_hparamswasn't added until torch 1.3.0. Right now, I just throw a warning and skip writting hparams to Tensorboard. The only other thing I can think of would be to write the hparams to a text file in the same directory as the TB logs.Closes #588
Closes #265