Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version_ prefix to log_dir #706

Merged
merged 2 commits into from Jan 18, 2020
Merged

add version_ prefix to log_dir #706

merged 2 commits into from Jan 18, 2020

Conversation

matthew-z
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #704

@williamFalcon
Copy link
Contributor

@matthew-z looks like one of the tests failed

@matthew-z
Copy link
Contributor Author

According to the unittest, the author intended to store each version name without ‘version_’ prefix. Do you think I should modify the unittest?

Borda
Borda approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda mentioned this pull request Jan 18, 2020
Closed
4 tasks
@williamFalcon williamFalcon merged commit de2ccc0 into Lightning-AI:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TensorBoardLogger and ModelCheckpoint are not using the same folder by default
3 participants
@matthew-z @williamFalcon @Borda