Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version_ prefix to log_dir #706

Merged
merged 2 commits into from Jan 18, 2020
Merged

add version_ prefix to log_dir #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefd73c
add version_ prefix to log_dir
matthew-z Jan 17, 2020
cd60d54
add version_ prefix
matthew-z Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions pytorch_lightning/logging/tensorboard.py
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@ def experiment(self):

root_dir = os.path.join(self.save_dir, self.name)
os.makedirs(root_dir, exist_ok=True)
log_dir = os.path.join(root_dir, str(self.version))
log_dir = os.path.join(root_dir, "version_" + str(self.version))
self._experiment = SummaryWriter(log_dir=log_dir, **self.kwargs)
return self._experiment

Expand Down Expand Up @@ -131,9 +131,11 @@ def version(self):

def _get_next_version(self):
root_dir = os.path.join(self.save_dir, self.name)
existing_versions = [
int(d) for d in os.listdir(root_dir) if os.path.isdir(os.path.join(root_dir, d)) and d.isdigit()
]
existing_versions = []
for d in os.listdir(root_dir):
if os.path.isdir(os.path.join(root_dir, d)) and d.startswith("version_"):
existing_versions.append(int(d.split("_")[1]))

if len(existing_versions) == 0:
return 0
else:
Expand Down
10 changes: 5 additions & 5 deletions tests/test_logging.py
View file
Open in desktop
Expand Up @@ -296,8 +296,8 @@ def test_tensorboard_automatic_versioning(tmpdir):
"""Verify that automatic versioning works"""

root_dir = tmpdir.mkdir("tb_versioning")
root_dir.mkdir("0")
root_dir.mkdir("1")
root_dir.mkdir("version_0")
root_dir.mkdir("version_1")

logger = TensorBoardLogger(save_dir=tmpdir, name="tb_versioning")

Expand All @@ -308,9 +308,9 @@ def test_tensorboard_manual_versioning(tmpdir):
"""Verify that manual versioning works"""

root_dir = tmpdir.mkdir("tb_versioning")
root_dir.mkdir("0")
root_dir.mkdir("1")
root_dir.mkdir("2")
root_dir.mkdir("version_0")
root_dir.mkdir("version_1")
root_dir.mkdir("version_2")

logger = TensorBoardLogger(save_dir=tmpdir, name="tb_versioning", version=1)

Expand Down