Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow overriding optimizer_zero_grad and/or optimizer_step when using accumulate_grad_batches #7980

Merged
merged 8 commits into from Jun 17, 2021

Conversation

DavidMChan
Copy link
Contributor

@DavidMChan DavidMChan commented Jun 14, 2021

What does this PR do?

Adds the ability to override optimizer_zero_grad when using accumulate_grad_batches as discussed in #6910

Fixes #6910

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #7980 (2a76b31) into master (bc2c2db) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7980    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     207            
  Lines       13374   13373     -1     
=======================================
- Hits        12246   11603   -643     
- Misses       1128    1770   +642     

@carmocca carmocca added the feature Is an improvement or enhancement label Jun 14, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 14, 2021
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/configuration_validator.py Outdated Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
@carmocca carmocca added the ready PRs ready to be merged label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding optimizer_zero_grad and/or optimizer_step when using accumulate_grad_batches
4 participants