Remove deprecation warnings being called for on_{task}_dataloader
#9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
kaushikb11
changed the title
on_{task}_dataloader
kaushikb11
requested review from
ananthsub,
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
rohitgr7
reviewed
Sep 6, 2021
rohitgr7
approved these changes
Sep 6, 2021
Borda
approved these changes
Sep 6, 2021
awaelchli
reviewed
Sep 6, 2021
| @@ -257,6 +257,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). | |||
| - Removed deprecated properties `DeepSpeedPlugin.cpu_offload*` in favor of `offload_optimizer`, `offload_parameters` and `pin_memory` ([#9244](https://github.com/PyTorchLightning/pytorch-lightning/pull/9244)) | |||
|
|
|||
|
|
|||
| - Removed deprecation warnings being called for `on_{task}_dataloader` ([#9279](https://github.com/PyTorchLightning/pytorch-lightning/pull/9279)) | |||
There was a problem hiding this comment.
this was added in #9098 so the changelog shouldn't mention it again here. it's not released
justusschock
pushed a commit
that referenced
this pull request
Sep 7, 2021
…9279) * Avoid deprecation warnings being called when hooks are not implemented * Update tests & changelog * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Conflicts: CHANGELOG.md pytorch_lightning/core/hooks.py tests/deprecated_api/test_remove_1-7.py tests/trainer/test_trainer.py
awaelchli
pushed a commit
that referenced
this pull request
Sep 7, 2021
…9279) * Avoid deprecation warnings being called when hooks are not implemented * Update tests & changelog * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Conflicts: CHANGELOG.md pytorch_lightning/core/hooks.py tests/deprecated_api/test_remove_1-7.py tests/trainer/test_trainer.py
lexierule
pushed a commit
that referenced
this pull request
Sep 10, 2021
…9279) * Avoid deprecation warnings being called when hooks are not implemented * Update tests & changelog * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Conflicts: CHANGELOG.md pytorch_lightning/core/hooks.py tests/deprecated_api/test_remove_1-7.py tests/trainer/test_trainer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9337
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃