Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with no-init dataclass fields in move_to_device #9963

Conversation

ronif
Copy link
Contributor

@ronif ronif commented Oct 16, 2021

What does this PR do?

Fixes #9930

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Oct 16, 2021
@awaelchli awaelchli added the bug Something isn't working label Oct 16, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 16, 2021
@awaelchli awaelchli added the data handling Generic data-related topic label Oct 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT Neat !

@mergify mergify bot added the ready PRs ready to be merged label Oct 16, 2021
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #9963 (b4a32c1) into master (e5dfdf3) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9963    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15838   15839     +1     
=======================================
- Hits        14678   14057   -621     
- Misses       1160    1782   +622     

@awaelchli awaelchli enabled auto-merge (squash) October 17, 2021 02:00
@awaelchli awaelchli merged commit 7b4df7b into Lightning-AI:master Oct 17, 2021
@ronif ronif deleted the bugfix/move-to-device-dataclass-no-init-fields branch October 17, 2021 08:21
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
…AI#9963)


Co-authored-by: ronif <ronif@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move_data_to_device fails with dataclasses with field(init=False) fields
4 participants