New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why use distributed data sampler for `redpajama.py` #649

Closed

larrylawl opened this issue Oct 17, 2023 · 1 comment

Contributor

larrylawl commented Oct 17, 2023 •

edited

Loading

Hi, can I check why did you use distributed data sampler here...

https://github.com/Lightning-AI/lit-gpt/blob/8641822b3249bb94f068c254aa5d13decbc9f0a0/pretrain/redpajama.py#L106

... when we are already splitting the data manually here?

https://github.com/Lightning-AI/lit-gpt/blob/8641822b3249bb94f068c254aa5d13decbc9f0a0/lit_gpt/packed_dataset.py#L48

larrylawl mentioned this issue

Possible bug in TinyLlama's dataloading jzhang38/TinyLlama#67

Closed

Contributor Author

larrylawl commented Oct 18, 2023

Resolved by Peiyuan in the issue above.

larrylawl closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment