Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi turn prompt #1487

Merged
merged 3 commits into from
Jun 13, 2024
Merged

add multi turn prompt #1487

merged 3 commits into from
Jun 13, 2024

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Jun 13, 2024

This PR adds multi-turn prompt handling for Llama3 as per the official model card prompt format here

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just extend the tests and we're good. Also please open an issue to extend multi-prompt for other models.

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lantiga lantiga merged commit 5766ea9 into main Jun 13, 2024
8 of 9 checks passed
@lantiga lantiga deleted the aniket/multi-turn-template branch June 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants