-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports #1491
Fix imports #1491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rasbt It would be nice if you could paste the error you got into the PR description. If the import order matters, it is often a sign of circular imports. And if that's the case, we should try to remove the circular dependency.
Good point @awaelchli . In this case it was not the circular dependency but issues with relative imports:
|
But we don't have any relative imports LitGPT. Of course, the expectation is that the package is installed. Did the user not install the package? How could changing the import order fix something like that? |
I don't know exactly why it is happening, but it's not the order but changing
to
etc. I remember having similar issues when implementing the API in #1463 even though I have LitGPT installed as a package. I don't fully understand why it's happening. |
Maybe @apaz-cli can provide more context here. |
Fixes an import issue Aaron was having.