Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-used eos_id in Python API #1594

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Remove non-used eos_id in Python API #1594

merged 2 commits into from
Jul 19, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Jul 18, 2024

The eos_id parameters was not used in the Python API. It can be removed because the eos_id is applied from the tokenizer directly. (It would be unreasonable for a user to know the eos_id because it's model dependent.)

@Andrei-Aksionov
Copy link
Collaborator

Don't forget to remove this line in the docstring too:

eos_id: If specified, stop generating any more token once the <eos> token is triggered.

@rasbt rasbt enabled auto-merge (squash) July 19, 2024 16:48
@rasbt rasbt merged commit 6ee05dd into main Jul 19, 2024
9 checks passed
@rasbt rasbt deleted the eos_id branch July 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants