Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply proposed changes by @RDouglasSharp from issue #57 #58 #60

Merged
merged 12 commits into from May 16, 2023
Merged

Apply proposed changes by @RDouglasSharp from issue #57 #58 #60

merged 12 commits into from May 16, 2023

Conversation

ArturK-85
Copy link
Contributor

@ArturK-85 ArturK-85 commented May 15, 2023

I apply proposed changes and tested it work good!

Fixes #58 #59 #61

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lit_parrot/adapter.py Outdated Show resolved Hide resolved
lit_parrot/config.py Show resolved Hide resolved
lit_parrot/adapter.py Outdated Show resolved Hide resolved
@lantiga lantiga merged commit ed8c9f5 into Lightning-AI:main May 16, 2023
4 checks passed
@ArturK-85
Copy link
Contributor Author

Thank you @lantiga !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cached KVs not implemented on Adapter causing errors.
4 participants