Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilabel support in ROC #114

Merged
merged 7 commits into from
Mar 23, 2021
Merged

Multilabel support in ROC #114

merged 7 commits into from
Mar 23, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 21, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #103
Adds multilabel support to ROC metric

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Nice addition !

@Borda
Copy link
Member

Borda commented Mar 23, 2021

@SkafteNicki mind resolve conflict, then ready to land :]

@Borda Borda added the ready label Mar 23, 2021
@Borda Borda enabled auto-merge (squash) March 23, 2021 17:52
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #114 (c95f4e1) into master (264cc6f) will decrease coverage by 17.36%.
The diff coverage is 86.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #114       +/-   ##
===========================================
- Coverage   97.24%   79.88%   -17.37%     
===========================================
  Files         122       70       -52     
  Lines        3990     2177     -1813     
===========================================
- Hits         3880     1739     -2141     
- Misses        110      438      +328     
Flag Coverage Δ
Linux 79.88% <86.64%> (+1.08%) ⬆️
Windows 79.88% <86.64%> (+1.08%) ⬆️
cpu 79.88% <86.64%> (-17.37%) ⬇️
gpu ?
macOS 79.88% <86.64%> (-17.37%) ⬇️
pytest 79.88% <86.64%> (-17.37%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.8.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/metric.py 55.25% <25.00%> (-38.98%) ⬇️
torchmetrics/functional/classification/auroc.py 46.15% <38.46%> (-39.10%) ⬇️
torchmetrics/functional/classification/accuracy.py 68.96% <50.00%> (-31.04%) ⬇️
torchmetrics/functional/regression/psnr.py 62.50% <57.14%> (-34.28%) ⬇️
...chmetrics/functional/classification/cohen_kappa.py 74.07% <66.66%> (-25.93%) ⬇️
torchmetrics/functional/regression/r2score.py 70.00% <66.66%> (-24.88%) ⬇️
torchmetrics/classification/auroc.py 83.78% <71.42%> (-7.89%) ⬇️
...rics/functional/classification/confusion_matrix.py 66.66% <75.00%> (-33.34%) ⬇️
...hmetrics/functional/retrieval/average_precision.py 80.00% <80.00%> (ø)
torchmetrics/regression/r2score.py 92.85% <80.00%> (+0.26%) ⬆️
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264cc6f...c95f4e1. Read the comment docs.

@Borda Borda removed the ready label Mar 23, 2021
@Borda
Copy link
Member

Borda commented Mar 23, 2021

@SkafteNicki seems that the tests are not correct

@SkafteNicki
Copy link
Member Author

@Borda thanks, had not run all test locally but they should be good now.

@Borda Borda merged commit 2af13fb into master Mar 23, 2021
@Borda Borda deleted the roc_multilabel_supp branch March 23, 2021 20:41
@Borda Borda added this to the 0.3 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-label ROCs
4 participants