Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ranking in spearman metric #448

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Fix ranking in spearman metric #448

merged 3 commits into from
Aug 16, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #444
Fix bug in the ranking function used in the spearman metric.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Aug 16, 2021
@SkafteNicki SkafteNicki added this to the v0.6 milestone Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #448 (07e4355) into master (18d500c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         129      129           
  Lines        4180     4180           
=======================================
  Hits         4013     4013           
  Misses        167      167           
Flag Coverage Δ
Linux 74.73% <0.00%> (ø)
Windows 74.73% <0.00%> (ø)
cpu 95.98% <100.00%> (+0.04%) ⬆️
gpu 95.93% <100.00%> (ø)
macOS 95.98% <100.00%> (+0.04%) ⬆️
pytest 96.00% <100.00%> (ø)
python3.6 ?
python3.8 95.98% <100.00%> (+0.04%) ⬆️
python3.9 ?
torch1.3.1 ?
torch1.4.0 95.31% <100.00%> (+0.04%) ⬆️
torch1.9.0 95.90% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/regression/spearman.py 97.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d500c...07e4355. Read the comment docs.

@Borda Borda enabled auto-merge (squash) August 16, 2021 10:12
@mergify mergify bot added the ready label Aug 16, 2021
@Borda Borda disabled auto-merge August 16, 2021 10:25
@Borda Borda merged commit 484477a into master Aug 16, 2021
@Borda Borda deleted the fix_spearman branch August 16, 2021 10:26
@Borda Borda modified the milestones: v0.6, v0.5 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpearmanCorrcoef bug due to incorrect ranking
3 participants