Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compute_on_step from aggregation and tests #990

Merged
merged 6 commits into from Apr 29, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 27, 2022

What does this PR do?

Fixes part of #956
Removes compute_on_step from aggregation + removes references to it in our testing setup

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@SkafteNicki SkafteNicki added the refactoring refactoring and code health label Apr 27, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #990 (d926c35) into master (452864b) will increase coverage by 24%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #990     +/-   ##
=======================================
+ Coverage      71%    95%    +24%     
=======================================
  Files         177    177             
  Lines        7522   7522             
=======================================
+ Hits         5323   7146   +1823     
+ Misses       2199    376   -1823     

@mergify mergify bot added the ready label Apr 27, 2022
@mergify mergify bot removed the has conflicts label Apr 28, 2022
@SkafteNicki SkafteNicki merged commit eb4cfaf into master Apr 29, 2022
@SkafteNicki SkafteNicki deleted the cleanup/compute_on_step_aggregation branch April 29, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants