Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Laverne Henderson <laverne.henderson@coupa.com>
  • Loading branch information
Borda and Felonious-Spellfire committed Sep 12, 2022
1 parent 8030197 commit 61c91db
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/lightning_app/cli/lightning_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def _run_app(
)
if secret:
raise click.ClickException(
"Secrets can only be used for apps running in cloud. "
"Secrets can only be used for Apps running in cloud. "
"Using the option --secret in local execution is not supported."
)

Expand Down
2 changes: 1 addition & 1 deletion src/lightning_app/runners/runtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def dispatch(
on_before_run: Callable to be executed before run.
name: Name of app execution
env_vars: Dict of env variables to be set on the app
secrets: Dict of secrets to be passed as environment variables to the app
secrets: Dict of secrets to be passed as environment variables to the App
cluster_id: the Lightning AI cluster to run the app on. Defaults to managed Lightning AI cloud
"""
from lightning_app.runners.runtime_type import RuntimeType
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_app/cli/test_run_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_lightning_run_app_cloud(mock_dispatch: mock.MagicMock, open_ui, caplog,


def test_lightning_run_app_secrets(monkeypatch):
"""Validates that running apps only supports the `--secrets` argument if the `--cloud` argument is passed."""
"""Validates that running Apps only supports the `--secrets` argument if the `--cloud` argument is passed."""
monkeypatch.setattr("lightning_app.runners.cloud.logger", logging.getLogger())

with pytest.raises(click.exceptions.ClickException):
Expand Down

0 comments on commit 61c91db

Please sign in to comment.