Make sure save_dir can be empty str (#15638)

Lightning-AI · Nov 11, 2022 · c53dc20 · c53dc20
1 parent 164e5a7
commit c53dc20
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/pytorch_lightning/callbacks/model_checkpoint.py b/src/pytorch_lightning/callbacks/model_checkpoint.py
@@ -584,7 +584,10 @@ def __resolve_ckpt_dir(self, trainer: "pl.Trainer") -> _PATH:
             return self.dirpath
 
         if len(trainer.loggers) > 0:
-            save_dir = trainer.loggers[0].save_dir or trainer.default_root_dir
+            if trainer.loggers[0].save_dir is not None:
+                save_dir = trainer.loggers[0].save_dir
+            else:
+                save_dir = trainer.default_root_dir
             name = trainer.loggers[0].name
             version = trainer.loggers[0].version
             version = version if isinstance(version, str) else f"version_{version}"