Skip to content

Commit

Permalink
[App] Fix e2e tests (#16146)
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanwharris committed Dec 20, 2022
1 parent bf8e568 commit c98b0c4
Showing 1 changed file with 18 additions and 28 deletions.
46 changes: 18 additions & 28 deletions src/lightning_app/testing/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,34 +386,24 @@ def run_app_in_cloud(
process = Process(target=_print_logs, kwargs={"app_id": app_id})
process.start()

if not app.spec.is_headless:
while True:
try:
with admin_page.context.expect_page() as page_catcher:
admin_page.locator('[data-cy="open"]').click()
view_page = page_catcher.value
view_page.wait_for_load_state(timeout=0)
break
except (playwright._impl._api_types.Error, playwright._impl._api_types.TimeoutError):
pass
else:
view_page = None

# Wait until the app is running
while True:
sleep(1)

lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]

if app.status.phase == V1LightningappInstanceState.RUNNING:
break
# Wait until the app is running
while True:
sleep(1)

lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]

if app.status.phase == V1LightningappInstanceState.RUNNING:
break

view_page = context.new_page()
view_page.goto(f"{app.status.url}/view")

# TODO: is re-creating this redundant?
lit_apps = [
Expand Down

0 comments on commit c98b0c4

Please sign in to comment.