Replace tmpdir usage with tmp_path in our tests

[carmocca]

Outline & Motivation

tmpdir is considered legacy:

The tmpdir and tmpdir_factory fixtures are similar to tmp_path and tmp_path_factory, but use/return legacy py.path.local objects rather than standard pathlib.Path objects.

(from https://docs.pytest.org/en/7.1.x/how-to/tmp_path.html#the-tmpdir-and-tmpdir-factory-fixtures)

Pitch

Run pytest with pytest -p no:legacypath as the link above suggests and replace all occurrences.

This can be added in https://github.com/Lightning-AI/lightning/blob/94e6d52b7e2f2a9ffc21f7e11e087808666fe710/setup.cfg#L28-L32

 addopts =
     --strict-markers
     --doctest-modules
     --color=yes
     --disable-pytest-warnings
     --ignore=legacy/checkpoints
+    -p no:legacypath

Replace all tmpdir usages

Additional context

No response

cc @Borda

[yhl48]

Happy to contribute to this issue if no one has been assigned to it!

[subham73]

Hello, @yhl48 are you still working on this? I'm planning to work on this, would love to have your input on this. Thanks

[Aditi840]

@carmocca, in which file tmpdir with tmp_path should be replaced

[Borda]

@carmocca, in which file tmpdir with tmp_path should be replaced

in all files :)

[Aditi840]

All files of lightning-AI, can I work on it.

[Aditi840]

All files of lightning-AI, can I work on it.

[Borda]

All files of lightning-AI, can I work on it.

Let's split is per topic:

• integrations_app + legacy [no occurrence of tmpdir]
• parity_fabric + parity_pytorch
• tests_app
• tests_data <- replace tmpdir by tmp_path in tests_data #18604
• tests_fabric
• tests_pytorch
• tests_store [no occurrence of tmpdir]

[Aditi840]

May I do the above 4 files.

[Aditi840]

@Borda Got it, replacements have to be done on tests file, I'm starting working on tests files.

[Aditi840]

@Borda will you please check my pull request and the changes I have done.

[Borda]

@Borda will you please check my pull request and the changes I have done.

I think it would be easier/faster if you create a PR per check item here: #16188 (comment)

[Aditi840]

@Borda , what we should do files, give me a idea

[Borda]

@Borda , what we should do files, give me a idea

Let's create another PR and perform replacement just for one sub folder as listed in comment/check-list above...

[Aditi840]

@Borda what replacement do we need to perform and on which sub-folder

[Borda]

@Borda what replacement do we need to perform and on which sub-folder

Could you please ping me on slack, would be easier to explain =)

[Aditi840]

@Borda , yaa sure tell me your slack Id

[Borda]

@Borda , yaa sure tell me your slack Id

You can find me as Jirka :)
I made a sample partial fix, so based on partitions in #16188 (comment), I just chose a topic/folder and tried to apply changes...

1. chose one folder and create a draft PR (which can be almost empty) that we can link the issues
2. take it file by file and perform replacement
3. I would suggest each file change shall be one commit in the PR so it is easier to trace what changes are not compatible

[Aditi840]

@Borda ok, will do that.

[Borda]

@Borda ok, will do that.

see sample #18604

[fnhirwa]

@Borda is this still open for contribution, I would love to work on it 😊

[Borda]

@Borda is this still open for contribution, I would love to work on it 😊

great, I can still see many places where this would need to be replaced :)