Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics backwards compatibility #5061

Closed
teddykoker opened this issue Dec 10, 2020 · 3 comments · Fixed by #5062 or #5067
Closed

Fix metrics backwards compatibility #5061

teddykoker opened this issue Dec 10, 2020 · 3 comments · Fixed by #5062 or #5067
Labels
help wanted Open to be worked on

Comments

@teddykoker
Copy link
Contributor

teddykoker commented Dec 10, 2020 •
edited
Loading

Moved to pl.metrics.utils (some users have complained about this)

TODO: add function back to functional (with deprecation warning) that simply calls new one
@teddykoker teddykoker added bug Something isn't working help wanted Open to be worked on labels Dec 10, 2020
@teddykoker teddykoker mentioned this issue Dec 10, 2020
Merged
@Borda
Copy link
Member

Borda commented Dec 10, 2020

it just about importing, so the fix is add in functional __init__ corrected in #5062

@edenlightning
Copy link
Contributor

@teddykoker @Borda can we close this?

@edenlightning edenlightning removed the bug Something isn't working label Dec 11, 2020
@edenlightning edenlightning changed the title Add deprecation for pl.metrics.functional.to_categorical Fix metrics backwards compatibility Dec 11, 2020
@edenlightning edenlightning linked a pull request Dec 11, 2020 that will close this issue
add back compatibility for deprecated metrics 1/n #5067
Merged
11 tasks
@edenlightning edenlightning mentioned this issue Dec 11, 2020
Merged
11 tasks
@Borda
Copy link
Member

Borda commented Dec 11, 2020

@teddykoker @Borda can we close this?

it is in #5067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
3 participants
@Borda @teddykoker @edenlightning