Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated APIs [TBD for v0.8.0] #780

Closed
Borda opened this issue Feb 2, 2020 · 10 comments · Fixed by #2073
Closed

remove deprecated APIs [TBD for v0.8.0] #780

Borda opened this issue Feb 2, 2020 · 10 comments · Fixed by #2073
Assignees
Labels
feature Is an improvement or enhancement good first issue Good for newcomers
Milestone

Comments

@Borda
Copy link
Member

Borda commented Feb 2, 2020

🚀 Feature

In version 0.5.3 and 0.6 was some API changed but for compatibility reasons we still keep it...
This deprecated API shall be cleaned in upcoming 0.8 release 🚀

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 2, 2020
@Borda Borda added this to the 0.8.0 milestone Feb 2, 2020
@Borda Borda added the good first issue Good for newcomers label Feb 2, 2020
@Borda
Copy link
Member Author

Borda commented Feb 8, 2020

Still thinking about the package name (not repo/project) that it is too long... I like something like torchlightning or just ptlightning =)
Join it with cleaning could be a good opportunity... 8-)

@williamFalcon williamFalcon changed the title cleaning deprecated API clean deprecated API Feb 11, 2020
@williamFalcon williamFalcon changed the title clean deprecated API remove deprecated APIs (v 0.8) Feb 11, 2020
@williamFalcon williamFalcon changed the title remove deprecated APIs (v 0.8) remove deprecated APIs (0.8.0) Feb 11, 2020
@williamFalcon
Copy link
Contributor

Nope. For now let's keep as is

@djbyrne
Copy link
Contributor

djbyrne commented Feb 14, 2020

Hi guys, I'd be happy to take this on. Really like the framework and would like to start contributing :)

@Borda
Copy link
Member Author

Borda commented Feb 14, 2020

sure, at this moment this is just reminder so we do not forget it.. lol
but sure, @djbyrne would you mind having look at some other "first issues" in the backlog

@Borda Borda changed the title remove deprecated APIs (0.8.0) remove deprecated APIs [TBD for v0.8.0] Feb 14, 2020
@djbyrne
Copy link
Contributor

djbyrne commented Feb 14, 2020

Yeah @Borda I'd be happy to. Could look at #714, i think thats the only remaining "good first issue" that doesn't have someone working on it

@djbyrne
Copy link
Contributor

djbyrne commented Feb 16, 2020

Hey @Borda I have a PR ready, but when I try to push my branch it says I dont have access to the repo. Do I need to be added to the repo list ?

@Borda
Copy link
Member Author

Borda commented Feb 16, 2020

You need to do branch in your forked repo and then make PR, but this is for long future because 0.8.0 is planed after couple months... So there is high chance of conflicts with other PRs
I would recommend to let it be and take other first good issue ;)
@djbyrne can we connect on Slack?

@Borda Borda removed the help wanted Open to be worked on label Feb 16, 2020
@djbyrne
Copy link
Contributor

djbyrne commented Feb 16, 2020

Ah I see, will do. Yeah for sure, is there a workspace for Pytorch Lightning?

@Borda
Copy link
Member Author

Borda commented Feb 16, 2020

@Borda Borda modified the milestones: 0.9, 0.8 Feb 27, 2020
@stale
Copy link

stale bot commented Apr 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 27, 2020
@Borda Borda removed the won't fix This will not be worked on label Apr 27, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@Borda Borda modified the milestones: 0.9.0, 0.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants