-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated API for v0.8 #2073
Conversation
fdb7568
to
2eb9c00
Compare
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-11 18:08:55 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 78 65 -13
Lines 4917 4858 -59
======================================
- Hits 4229 4174 -55
+ Misses 688 684 -4 |
This pull request is now in conflict... :( |
bb2a237
to
b2f47e4
Compare
b2f47e4
to
9b2e777
Compare
@PyTorchLightning/core-contributors mind review this, it is mandatory for v0.8.0 🐰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been looking forward to this, really cleans up the project a bit :)
* remove deprecated API * chlog * times * missed * formatting check * missing * missing * miss * fix docs build error * fix pep whitespace error * docs * wip * amp_level * amp_level Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> (cherry picked from commit 2674976)
What does this PR do?
Fixes #780
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃