remove deprecated API for v0.8 #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
ci
Borda
force-pushed
the
deprecated/clean-v0.8
branch
2 times, most recently
from
fdb7568
to
2eb9c00
Compare
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-11 18:08:55 UTC |
awaelchli
approved these changes
Jun 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 78 65 -13
Lines 4917 4858 -59
======================================
- Hits 4229 4174 -55
+ Misses 688 684 -4 |
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
deprecated/clean-v0.8
branch
from
bb2a237
to
b2f47e4
Compare
Borda
force-pushed
the
deprecated/clean-v0.8
branch
from
b2f47e4
to
9b2e777
Compare
|
@PyTorchLightning/core-contributors mind review this, it is mandatory for v0.8.0 🐰 |
awaelchli
approved these changes
Jun 11, 2020
SkafteNicki
approved these changes
Jun 12, 2020
Borda
added a commit
that referenced
this pull request
Jun 13, 2020
* remove deprecated API * chlog * times * missed * formatting check * missing * missing * miss * fix docs build error * fix pep whitespace error * docs * wip * amp_level * amp_level Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> (cherry picked from commit 2674976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #780
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃