New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningCLI changes for jsonargparse>=4.0.0 #10426
Merged
carmocca
merged 7 commits into
Lightning-AI:master
from
mauvilsa:jsonargparse-4-backward-compatible
Nov 19, 2021
Merged
LightningCLI changes for jsonargparse>=4.0.0 #10426
carmocca
merged 7 commits into
Lightning-AI:master
from
mauvilsa:jsonargparse-4-backward-compatible
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mauvilsa
changed the title
Check backard compatibility with jsonargparse>=4.0.0rc1
Check backward compatibility with jsonargparse>=4.0.0rc1
Nov 9, 2021
carmocca
reviewed
Nov 9, 2021
mauvilsa
changed the title
Check backward compatibility with jsonargparse>=4.0.0rc1
LightningCLI changes for jsonargparse>=4.0.0
Nov 17, 2021
mauvilsa
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
November 17, 2021 07:16
tchaton
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
approved these changes
Nov 19, 2021
carmocca
reviewed
Nov 19, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai>
ethanwharris
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes changes required in LightningCLI for jsonargparse 4.0.0 and the deprecated parse_as_dict.
Several issues are fixed with the new jsonargparse version though most of them not reported in github. A couple of fixes that were reported:
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃