-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate callback hooks on_init_start
and on_init_end
#10940
Merged
daniellepintz
merged 16 commits into
Lightning-AI:master
from
daniellepintz:on_init_start
Dec 8, 2021
Merged
Deprecate callback hooks on_init_start
and on_init_end
#10940
daniellepintz
merged 16 commits into
Lightning-AI:master
from
daniellepintz:on_init_start
Dec 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellepintz
requested review from
ananthsub,
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 4, 2021 20:57
…lightning into on_init_start
for more information, see https://pre-commit.ci
…tning into on_init_start
daniellepintz
commented
Dec 5, 2021
…lightning into on_init_start
ananthsub
reviewed
Dec 7, 2021
ananthsub
approved these changes
Dec 7, 2021
rohitgr7
reviewed
Dec 7, 2021
awaelchli
approved these changes
Dec 7, 2021
rohitgr7
approved these changes
Dec 7, 2021
for more information, see https://pre-commit.ci
tchaton
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10940 +/- ##
=========================================
+ Coverage 56% 88% +32%
=========================================
Files 177 177
Lines 16545 16526 -19
=========================================
+ Hits 9340 14548 +5208
+ Misses 7205 1978 -5227 |
…lightning into on_init_start
…tning into on_init_start
This was referenced Dec 16, 2021
This was referenced Jan 21, 2022
Closed
12 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10894
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃