Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate on_configure_sharded_model callback hook for v1.6 #11627

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Deprecate on_configure_sharded_model callback hook for v1.6 #11627

merged 7 commits into from
Feb 3, 2022

Conversation

Piyush-97
Copy link
Contributor

@Piyush-97 Piyush-97 commented Jan 26, 2022 •
edited

What does this PR do?

Fixes #11560

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

ananthsub
ananthsub reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the CHANGELOG as well. Thanks again for working on this!

pytorch_lightning/trainer/configuration_validator.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/base.py Outdated Show resolved Hide resolved
@ananthsub ananthsub added callback deprecation Includes a deprecation labels Jan 26, 2022
@ananthsub ananthsub added this to the 1.6 milestone Jan 26, 2022
@Piyush-97 @rohitgr7
Update pytorch_lightning/trainer/configuration_validator.py
6130490 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@Piyush-97 Piyush-97 marked this pull request as ready for review January 27, 2022 17:34
daniellepintz
daniellepintz approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitgr7 @daniellepintz
Update pytorch_lightning/callbacks/base.py
28cbce3 
Co-authored-by: Danielle Pintz <38207072+daniellepintz@users.noreply.github.com>
@mergify mergify bot added the ready PRs ready to be merged label Jan 27, 2022
awaelchli
awaelchli approved these changes Jan 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/base.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/base.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/configuration_validator.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tchaton
tchaton approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after applying comments.

@ananthsub @awaelchli
Apply suggestions from code review
e7e0054 
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@carmocca carmocca enabled auto-merge (squash) February 3, 2022 02:15
@carmocca carmocca merged commit 72f0e5b into Lightning-AI:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@daniellepintz daniellepintz daniellepintz approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
callback deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate on_configure_sharded_model callback hook
8 participants
@Piyush-97 @ananthsub @awaelchli @tchaton @akihironitta @rohitgr7 @daniellepintz @carmocca