Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin protobuf version and update tensorboard version #13259

Merged
merged 8 commits into from
Jun 29, 2022
Merged

Unpin protobuf version and update tensorboard version #13259

merged 8 commits into from
Jun 29, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jun 9, 2022 •
edited by github-actions bot

What does this PR do?

Follows up #13159. tensorboard>=2.9.1 pins the version until it's compatible with the latest protobuf, so there's no need to pin it on our end. tensorflow/tensorboard#5726 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@akihironitta akihironitta added the ci Continuous Integration label Jun 9, 2022
@akihironitta akihironitta added this to the 1.6.x milestone Jun 9, 2022
akihironitta
akihironitta commented Jun 9, 2022
View reviewed changes
requirements/base.txt Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jun 9, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 21, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Jun 22, 2022
@akihironitta akihironitta changed the title Unpin protobuf version Unpin protobuf version and update tensorboard version Jun 22, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@carmocca
Copy link
Contributor

For this to work in our CI, we would need to increase the minimum tensorboard version

@akihironitta akihironitta mentioned this pull request Jun 28, 2022
Closed
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 29, 2022
@akihironitta akihironitta merged commit 55e347b into master Jun 29, 2022
@akihironitta akihironitta deleted the req/unpin-protobuf branch June 29, 2022 18:44
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
rohitgr7 pushed a commit that referenced this pull request Jul 1, 2022
@akihironitta @Borda @rohitgr7
Unpin protobuf version and update tensorboard version (#13259)
7adfdfe 
* Remove protobuf from base req

* Update tensorboard version

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@akihironitta @Borda @jerome-habana
Unpin protobuf version and update tensorboard version (Lightning-…
b6a666a 
…AI#13259)

* Remove protobuf from base req

* Update tensorboard version

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
This was referenced Sep 23, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@otaj otaj otaj approved these changes

@carmocca carmocca carmocca approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akihironitta @carmocca @Borda @otaj @kaushikb11