Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete wrong condition from schedule call function #14065

Closed
wants to merge 20 commits into from
Closed

Delete wrong condition from schedule call function #14065

wants to merge 20 commits into from

Conversation

fedorovgv
Copy link

What does this PR do?

This PR fixes the work of the PyTorchProfiler with the schedule parameter. In this moment, profiler doesn't take into account the repeat parameter torch.profiler.schedule.

This parameter is very important for long-term learning, because we want to get a representative sample of step time statistics to better understand the time complexity of the various components. It's also important when we can't afford to record statistics for the entire epoch due to memory limitations.

Fixes #14063

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 6, 2022
@fedorovgv fedorovgv changed the title Delete wrong condition from schedule call function (#14063) Delete wrong condition from schedule call function Aug 10, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 21, 2022
@stale
Copy link

stale bot commented Oct 1, 2022

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule in PyTorchProfiler doesn't work
1 participant