-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete wrong condition from schedule call function #14065
Delete wrong condition from schedule call function #14065
Conversation
…bugfix/profiler-scheduler
for more information, see https://pre-commit.ci
…vgv/lightning into bugfix/profiler-scheduler
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master. |
What does this PR do?
This PR fixes the work of the
PyTorchProfiler
with theschedule
parameter. In this moment, profiler doesn't take into account therepeat
parametertorch.profiler.schedule
.This parameter is very important for long-term learning, because we want to get a representative sample of step time statistics to better understand the time complexity of the various components. It's also important when we can't afford to record statistics for the entire epoch due to memory limitations.
Fixes #14063
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃