add rank warning

[Borda]

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[Borda]

now it is implemented only for model, but shall we doe rank warning also for callbacks?

[williamFalcon]

i think it needs to be a standalone package.

from pl import warnings

# from trainer.__init__
warnings.set_rank(rank)

# anywhere now including a lightning  module,   trainer, etc.
warnings.rank_zero_warn()

don't make it so we have to instantiate an instance... also instance doesn't make sense since we just need to call it from wherever.

[williamFalcon]

see comments

[williamFalcon]

Also, replace all the warnings across the project with this.

[Borda]

but the rank is depending on the backend so you cannot use a global rank value... can you?

[codecov]

Codecov Report

Merging #1428 into master will decrease coverage by 0%.
The diff coverage is 85%.

@@           Coverage Diff           @@
##           master   #1428    +/-   ##
=======================================
- Coverage      92%     92%    -0%     
=======================================
  Files          63      66     +3     
  Lines        3404    3508   +104     
=======================================
+ Hits         3123    3212    +89     
- Misses        281     296    +15     

[Borda]

warnings.rank_zero_warn()

but this has to have an extra parameter of the actual rank...
so we can have warning called from where ever but not with rank specific

[williamFalcon]

warnings inside lightning are ALL rank specific.

[pep8speaks]

Hello @Borda! Thanks for updating this PR.

• In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 206:111: E501 line too long (116 > 110 characters)

• In the file pytorch_lightning/trainer/trainer.py:

Line 957:111: E501 line too long (119 > 110 characters)

Comment last updated at 2020-04-09 17:26:48 UTC