Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Muse #15005

Merged
merged 7 commits into from Oct 7, 2022
Merged

Update for Muse #15005

merged 7 commits into from Oct 7, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 5, 2022 •
edited by github-actions bot

What does this PR do?

some minor fixes...

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @tchaton @rohitgr7 @Borda

@github-actions github-actions bot added the app Generic label for Lightning App package label Oct 5, 2022
@Borda Borda added this to the app:0.6.x milestone Oct 5, 2022
awaelchli
awaelchli approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda I think it should say in the description that this is cherry picking
2721a2f

This helps the reviewer.

@Borda
Copy link
Member Author

Borda commented Oct 5, 2022

I think it should say in the description that this is cherry picking 2721a2f

This helps the reviewer.

You are right, it is just not sure what all needs to be picked, so switching back to draft...

@Borda Borda marked this pull request as draft October 5, 2022 23:24
@Borda
Copy link
Member Author

Borda commented Oct 5, 2022

also we need to get #14972

@Borda Borda added priority: 1 Medium priority task release labels Oct 5, 2022
@otaj
Copy link
Contributor

otaj commented Oct 6, 2022

@Borda please also cherry-pick #14975, otherwise tests are failing

@otaj
Copy link
Contributor

otaj commented Oct 6, 2022

Although it's for pytorch portion, it is needed since doctests for app are importing pytorch portion as well

@otaj @Borda
Bump version of fsspec (#14975)
05f008c 
fsspec verbump

(cherry picked from commit e290c20)
@github-actions github-actions bot removed the app Generic label for Lightning App package label Oct 6, 2022
@pritamsoni-hsr @Borda
feat: allow root path to run the app on /path (#14972)
c5fd8cd 
* feat: add base path
* uvicorn fix arg
* Add prefix
* update with base_path fix
* replace base path with root path
* Apply suggestions from code review

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 8008055)
@Borda Borda marked this pull request as ready for review October 7, 2022 14:12
@Borda Borda requested a review from hhsecond as a code owner October 7, 2022 14:12
@codecov
Copy link

codecov bot commented Oct 7, 2022 •
edited

Codecov Report

Merging #15005 (d498887) into release/app (c1c233c) will increase coverage by 0%.
The diff coverage is 53%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release/app   #15005    +/-   ##
=============================================
  Coverage           84%      85%            
=============================================
  Files              359      360     +1     
  Lines            27253    27303    +50     
=============================================
+ Hits             23016    23187   +171     
+ Misses            4237     4116   -121

tchaton
tchaton approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 7, 2022
@Borda Borda enabled auto-merge (rebase) October 7, 2022 20:01
@lexierule lexierule merged commit 9417739 into release/app Oct 7, 2022
@lexierule lexierule deleted the update/muse branch October 7, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj otaj approved these changes

@manskx manskx manskx approved these changes

@tchaton tchaton tchaton approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

@hhsecond hhsecond Awaiting requested review from hhsecond

Assignees
No one assigned
Labels
priority: 1 Medium priority task ready PRs ready to be merged release
Projects
None yet
Milestone
app:0.6.x
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Borda @otaj @awaelchli @manskx @tchaton @lexierule @pritamsoni-hsr @carmocca