Reuse assistant code to create the mirror package #15365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
williamFalcon,
Borda,
tchaton,
awaelchli,
kaushikb11 and
rohitgr7
as code owners
carmocca
changed the title
copy_replace_importscopy_replace_imports
carmocca
force-pushed
the
ci/reuse-copy-code
branch
from
4f0e126
to
26abffb
Compare
carmocca
force-pushed
the
ci/reuse-copy-code
branch
from
44cd4d6
to
b978041
Compare
carmocca
commented
Nov 4, 2022
Comment on lines
+73
to
+74
| setup_tools = _load_py_module(name="setup_tools", location=os.path.join(_PATH_ROOT, ".actions", "setup_tools.py")) | ||
| assistant = _load_py_module(name="assistant", location=os.path.join(_PATH_ROOT, ".actions", "assistant.py")) |
There was a problem hiding this comment.
(not for this PR) I think these 2 files could be merged. Is there any advantage to having them separated?
carmocca
changed the title
copy_replace_imports
akihironitta
approved these changes
Nov 7, 2022
justusschock
approved these changes
Nov 8, 2022
Borda
reviewed
Nov 8, 2022
Borda
reviewed
Nov 8, 2022
Borda
reviewed
Nov 8, 2022
carmocca
requested review from
Borda
and removed request for
otaj,
rohitgr7 and
kaushikb11
Borda
approved these changes
Nov 8, 2022
Borda
pushed a commit
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit e33d09a)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
(cherry picked from commit e33d09a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes https://github.com/Lightning-AI/lightning/pull/15105/files#r1002933959
Also prunes a bunch of unused code
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @carmocca @akihironitta @Borda