Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytorch_lightning.profiler.{AbstractProfiler,BaseProfiler} deprecated since v1.6 #15637

Merged
merged 13 commits into from
Nov 23, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Nov 11, 2022

What does this PR do?

Closes #15618.
Missed in #14404.
resolves #12106

Does your PR introduce any breaking changes? If yes, please list them.

Removes these two deprecated classes:

pytorch_lightning.profiler.base.AbstractProfiler
pytorch_lightning.profiler.base.BaseProfiler

in favor of:

pytorch_lightning.profilers.profiler.Profiler

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @nbcsm @guotuofeng @Borda @justusschock

@akihironitta akihironitta added profiler breaking change Includes a breaking change labels Nov 11, 2022
@akihironitta akihironitta added this to the v1.9 milestone Nov 11, 2022
@akihironitta akihironitta self-assigned this Nov 11, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 11, 2022
src/pytorch_lightning/_graveyard/profiler.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 11, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Nov 12, 2022
@akihironitta akihironitta enabled auto-merge (squash) November 14, 2022 02:50
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 14, 2022
@Borda
Copy link
Member

Borda commented Nov 22, 2022

@akihironitta mind checking the remaining issues (mypy)?

@akihironitta
Copy link
Contributor Author

Let me finish up this PR tomorrow (as tomorrow is a bank holiday and I will have time).

@akihironitta akihironitta marked this pull request as draft November 22, 2022 09:20
auto-merge was automatically disabled November 22, 2022 09:20

Pull request was converted to draft

@mergify mergify bot removed the ready PRs ready to be merged label Nov 22, 2022
@akihironitta akihironitta marked this pull request as ready for review November 23, 2022 12:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success
pl-cpu (macOS-11, lightning, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.13) success
🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success
🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success
🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success
🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success
🟢 mypy
Check ID Status
mypy success
🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, lite, 3.7) success
install-pkg (ubuntu-22.04, lite, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, lite, 3.7) success
install-pkg (macOS-12, lite, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, lite, 3.7) success
install-pkg (windows-2022, lite, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success

This comment was automatically generated and updates for 60 minutes every 180 seconds.

Thank you for your contribution! 💜

@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2022
@akihironitta
Copy link
Contributor Author

Still wip. Marked this PR as ready to trigger CI.

@akihironitta
Copy link
Contributor Author

This is now ready. The only change since the two approvals is the annotation for the APIs buried in the graveyard 🪦

@akihironitta akihironitta enabled auto-merge (squash) November 23, 2022 13:08
@akihironitta akihironitta merged commit b682d4c into master Nov 23, 2022
@akihironitta akihironitta deleted the remove-deprecated-base-profiler branch November 23, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package profiler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated APIs that should've been removed in the past releases
4 participants