Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Revert "Improving Hydra+DDP support (#11617)" #15727

Closed
wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Nov 18, 2022

This reverts commit 45ca781 (#11617).

Fixes #15689

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭
Make sure you had fun coding 馃檭

cc @tchaton @justusschock @awaelchli @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 18, 2022
@awaelchli awaelchli added 3rd party Related to a 3rd-party strategy: ddp DistributedDataParallel priority: 1 Medium priority task labels Nov 18, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 18, 2022
@awaelchli awaelchli changed the title Revert "Improving Hydra+DDP support (#11617)" WIP: Revert "Improving Hydra+DDP support (#11617)" Nov 18, 2022
@awaelchli awaelchli marked this pull request as ready for review November 18, 2022 12:56
@awaelchli awaelchli marked this pull request as draft November 19, 2022 15:33
@Borda Borda closed this in #15737 Nov 21, 2022
@awaelchli awaelchli deleted the feature/revert-11617 branch November 26, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party pl Generic label for PyTorch Lightning package priority: 1 Medium priority task strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra + DDP Fails for NeMo after Hydra refactor in 1.8
1 participant