Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loggers: revert useless exception #15789

Merged
merged 4 commits into from
Dec 20, 2022
Merged

loggers: revert useless exception #15789

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d01baa
revert useless exception
Borda Nov 23, 2022
1c7cea4
Merge branch 'master' into refactor/tbx
Borda Dec 5, 2022
21e1ee7
Merge branch 'master' into refactor/tbx
Borda Dec 13, 2022
7861a64
Merge branch 'master' into refactor/tbx
Borda Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/pytorch_lightning/loggers/tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
log = logging.getLogger(__name__)

_TENSORBOARD_AVAILABLE = RequirementCache("tensorboard")
_TENSORBOARDX_AVAILABLE = RequirementCache("tensorboardX")
if TYPE_CHECKING:
# assumes at least one will be installed when type checking
if _TENSORBOARD_AVAILABLE:
Expand Down Expand Up @@ -114,10 +113,6 @@ def __init__(
sub_dir: Optional[_PATH] = None,
**kwargs: Any,
):
if not _TENSORBOARD_AVAILABLE and not _TENSORBOARDX_AVAILABLE:
Borda marked this conversation as resolved.
Show resolved Hide resolved
raise ModuleNotFoundError(
"Neither `tensorboard` nor `tensorboardX` is available. Try `pip install`ing either."
)
super().__init__()
save_dir = os.fspath(save_dir)
self._save_dir = save_dir
Expand Down