Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for colossalai 0.1.11 #15888

Merged
merged 18 commits into from
Dec 20, 2022
Merged

Add support for colossalai 0.1.11 #15888

merged 18 commits into from
Dec 20, 2022

Conversation

1SAA
Copy link
Contributor

@1SAA 1SAA commented Dec 2, 2022 •
edited by Borda

What does this PR do?

Update the APIs in ColossalAIStrategy for its new version.
Since the API of Gemini in ColossalAI has updated recently, it becames incompatible with Lightning.
For compatibility with the upcoming version 0.1.11, I updated the ColossalAIStrategy.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 2, 2022
tchaton
tchaton reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some unit tests ?

src/pytorch_lightning/strategies/colossalai.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added strategy: colossalai (removed) Colossal-AI feature Is an improvement or enhancement labels Dec 5, 2022
@awaelchli awaelchli added this to the v1.9 milestone Dec 5, 2022
@1SAA
Copy link
Contributor Author

1SAA commented Dec 5, 2022

@tchaton It is a good suggestion. I think I can add some new unit tests.

awaelchli
awaelchli approved these changes Dec 7, 2022
View reviewed changes
src/pytorch_lightning/strategies/colossalai.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 12, 2022
@carmocca carmocca changed the title [strategy] Update colossalai strategy Add support for colossalai 0.1.10 Dec 12, 2022
@carmocca carmocca enabled auto-merge (squash) December 12, 2022 14:03
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Dec 12, 2022
@Borda Borda requested a review from tchaton December 14, 2022 14:12
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 14, 2022
auto-merge was automatically disabled December 16, 2022 07:39

Head branch was pushed to by a user without write access

carmocca
carmocca approved these changes Dec 16, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca changed the title Add support for colossalai 0.1.10 Add support for colossalai 0.1.11 Dec 16, 2022
@carmocca
Copy link
Contributor

The mypy checks are failing: https://github.com/Lightning-AI/lightning/actions/runs/3711224217/jobs/6291426057

@Borda Borda merged commit 5e6f9b5 into Lightning-AI:master Dec 20, 2022
@Borda
Copy link
Member

Borda commented Dec 20, 2022

seems there are no stable release yet so going to temporarily drop testing in #16122

carmocca added a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca @Borda
Add support for colossalai 0.1.11 (#15888)
3660e6e 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
carmocca added a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca @Borda
Add support for colossalai 0.1.11 (#15888)
743abdd 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
carmocca added a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca @Borda
Add support for colossalai 0.1.11 (#15888)
45cdbdb 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
carmocca added a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca @Borda
Add support for colossalai 0.1.11 (#15888)
a7fece4 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
carmocca added a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca @Borda
Add support for colossalai 0.1.11 (#15888)
42cf0db 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
nicolai86 pushed a commit that referenced this pull request Dec 20, 2022
@1SAA @carmocca
@Borda @nicolai86
Add support for colossalai 0.1.11 (#15888)
ec5b791 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: colossalai (removed) Colossal-AI
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1SAA @carmocca @Borda @awaelchli @tchaton