Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Refactor cloud dispatch and update to new API #16456

Merged
merged 13 commits into from
Jan 23, 2023
Merged

[App] Refactor cloud dispatch and update to new API #16456

merged 13 commits into from
Jan 23, 2023

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Jan 20, 2023 •
edited

What does this PR do?

  • Updates cloud dispatch to the new API
  • breaks down the large method into several smaller ones and calls them in a consistent order (e.g. so we don't raise errors after things have started to happen)
  • adds the option to export LIGHTNING_CLOUD_PRINT_SPECS=gallery or LIGHTNING_CLOUD_PRINT_SPECS=web to generate app specs for use in the gallery or web dispatch

Note: Tests left deliberately as unchanged as possible to ensure that the core logic hasn't changed.

Fixes #15012

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app Generic label for Lightning App package label Jan 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py, tests/tests_app/cli/test_cloud_cli.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_app_helpers.py, requirements/app/base.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py, tests/integrations_app/public/test_commands_and_api.py, requirements/app/base.txt.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py, requirements/app/base.txt, tests/integrations_app/public/test_commands_and_api.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py, requirements/app/base.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/base.txt, src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/runners/cloud.py, src/lightning_app/source_code/copytree.py, src/lightning_app/source_code/local.py, src/lightning_app/utilities/clusters.py, requirements/app/base.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@ethanwharris ethanwharris changed the title [WIP] [App] Refactor cloud dispatch and update to new API [App] Refactor cloud dispatch and update to new API Jan 20, 2023
@ethanwharris ethanwharris self-assigned this Jan 20, 2023
carmocca
carmocca approved these changes Jan 21, 2023
View reviewed changes
requirements/app/base.txt Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addresses #15012 too. Would you agree?

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning_app/source_code/local.py Show resolved Hide resolved
src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 22, 2023
ethanwharris and others added 4 commits January 23, 2023 10:23
@ethanwharris @carmocca @awaelchli
Apply suggestions from code review
9ddc003 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@ethanwharris
Move public methods to top
e5379f7
@ethanwharris
Try something
64ac2e1
@ethanwharris
Connect to / lookup app by name
7d79acc
@ethanwharris ethanwharris enabled auto-merge (squash) January 23, 2023 11:43
@ethanwharris ethanwharris merged commit 04886ed into master Jan 23, 2023
@ethanwharris ethanwharris deleted the feature/cloudspace_dispatch branch January 23, 2023 12:41
Borda pushed a commit that referenced this pull request Feb 9, 2023
@ethanwharris @Borda
[App] Refactor cloud dispatch and update to new API (#16456)
e1e30b8 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 04886ed)
@awaelchli awaelchli added this to the v1.9.x milestone Feb 10, 2023
lantiga pushed a commit that referenced this pull request Feb 10, 2023
@ethanwharris @lantiga
[App] Refactor cloud dispatch and update to new API (#16456)
0aea257 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 04886ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@ethanwharris ethanwharris

Labels
app Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.

Split out CloudRuntime.dispatch into multiple methods
3 participants
@ethanwharris @awaelchli @carmocca