Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Add lightning open command #16482

Merged
merged 10 commits into from
Jan 24, 2023
Merged

[App] Add lightning open command #16482

merged 10 commits into from
Jan 24, 2023

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Jan 23, 2023

What does this PR do?

Adds the lightning open command (early access, not currently enabled for all users)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@ethanwharris ethanwharris added app Generic label for Lightning App package app:cli app:cloud labels Jan 23, 2023
@ethanwharris ethanwharris added this to the v1.9.x milestone Jan 23, 2023
@ethanwharris ethanwharris self-assigned this Jan 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success
app-pytest (macOS-11, app, 3.8, oldest) success
app-pytest (macOS-11, lightning, 3.9, latest) success
app-pytest (ubuntu-20.04, app, 3.8, latest) success
app-pytest (ubuntu-20.04, app, 3.8, oldest) success
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.8, oldest) success
app-pytest (windows-2022, lightning, 3.8, latest) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, tests/tests_app/runners/test_cloud.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success
app-examples (macOS-11, app, 3.9, oldest) success
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, oldest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (windows-2022, app, 3.9, latest) success
app-examples (windows-2022, app, 3.9, oldest) success
app-examples (windows-2022, lightning, 3.9, latest) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success
make-html (app) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.7) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.7) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.7) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning_app/runners/cloud.py Show resolved Hide resolved
src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning_app/runners/cloud.py Show resolved Hide resolved
src/lightning_app/runners/cloud.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@rlizzo rlizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions and comments here. mostly documentation and user output related. code looks good

src/lightning_app/cli/lightning_cli.py Outdated Show resolved Hide resolved
src/lightning_app/cli/lightning_cli.py Outdated Show resolved Hide resolved
src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rlizzo rlizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the comment updates!

@mergify mergify bot added the ready PRs ready to be merged label Jan 24, 2023
@ethanwharris ethanwharris merged commit 4a802e0 into master Jan 24, 2023
@ethanwharris ethanwharris deleted the feature/lightning_open branch January 24, 2023 15:58
Borda pushed a commit that referenced this pull request Feb 9, 2023
lantiga pushed a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:cli app:cloud app Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants