Add FileSystem #16581
Merged
Add FileSystem #16581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2023 14:31
for more information, see https://pre-commit.ci
tchaton
requested review from
lantiga,
awaelchli,
hhsecond and
ethanwharris
as code owners
for more information, see https://pre-commit.ci
lantiga
requested changes
Jan 31, 2023
added 3 commits
February 1, 2023 08:57
…I/lightning into storage_improvements
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…I/lightning into storage_improvements
for more information, see https://pre-commit.ci
…I/lightning into storage_improvements
for more information, see https://pre-commit.ci
…I/lightning into storage_improvements
…I/lightning into storage_improvements
for more information, see https://pre-commit.ci
lantiga
approved these changes
Feb 1, 2023
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
Borda
pushed a commit
that referenced
this pull request
Feb 9, 2023
Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 695fb6a)
Borda
pushed a commit
that referenced
this pull request
Feb 9, 2023
Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 695fb6a)
lantiga
pushed a commit
that referenced
this pull request
Feb 10, 2023
Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 695fb6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces FileSystem to simplify interaction with files. It doesn't support project files manipulation.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda